[weboob] [PATCH] Replacing print calls by proper logger calls

Phyks phyks at phyks.me
Fri Oct 7 02:14:28 CEST 2016


Indeed, it was a mistake. Here is an updated patch.

I could not find a use case where the message would not be shown to the
user, but I may have missed something.
-- 
Phyks

Le 05/10/2016 à 11:58, Laurent Bachelier a écrit :
> On 2016-10-02 22:50, Phyks wrote:
>> +            self.logger.info('Debug data will be saved in this directory: %s',
>> +                             self.responses_dirname, file=sys.stderr)
> 
> I don't think the file=sys.stderr should be there. It was used for
> print(), but the logger has its own criteria to decide where to print.
> 
> Also, we should be sure the user will be able to see this message. I
> don't remember if sometimes we save the response even if the user didn't
> ask for it, and the logging level may hide the message. I haven't been
> able to find it so I might be imagining things.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-print-and-use-logger-features-in-parts-that-c.patch
Type: text/x-patch
Size: 1649 bytes
Desc: not available
URL: <https://lists.symlink.me/pipermail/weboob/attachments/20161007/a19bb3cd/attachment.bin>


More information about the weboob mailing list