[weboob] [PATCH] Replacing print calls by proper logger calls

Laurent Bachelier laurent at bachelier.name
Wed Oct 5 11:58:13 CEST 2016


On 2016-10-02 22:50, Phyks wrote:
> +            self.logger.info('Debug data will be saved in this directory: %s',
> +                             self.responses_dirname, file=sys.stderr)

I don't think the file=sys.stderr should be there. It was used for
print(), but the logger has its own criteria to decide where to print.

Also, we should be sure the user will be able to see this message. I
don't remember if sometimes we save the response even if the user didn't
ask for it, and the logging level may hide the message. I haven't been
able to find it so I might be imagining things.



More information about the weboob mailing list