[weboob] [PATCH 1/2] let bcall_error_handler handle NotImplementedError

Pierre-Louis Bonicoli pierre-louis.bonicoli at gmx.fr
Wed Jul 29 11:32:57 CEST 2015


On 28/07/2015 21:47, Flo wrote:
> If I good remember, the goal was here to not break the call when
> only one module was failing. What is your motivation to remove it?

Hi,

The motivation: ConsoleApplication.bcall_error_handler prints a better
message: "To help the maintainer of this backend implement this feature,
please contact <maintainer>" [1].


The call is not broken when one module fails, the exception is caught
and not reraised [1]. For example using ameli and freemobile modules:

boobill> balance 1,2
 Error(freemobile):
 this feature is not supported yet by this backend.
 To help the maintainer of this backend implement this feature,
 please contact: Florent Fourcot <freemobile at issues.weboob.org>
 Error(ameli):
 this feature is not supported yet by this backend.
 To help the maintainer of this backend implement this feature,
 please contact: Christophe Lampin <ameli at issues.weboob.org>


[1]
https://symlink.me/projects/weboob/repository/revisions/master/entry/weboob/tools/application/console.py#L548

--
Pierre-Louis



More information about the weboob mailing list