[weboob] [PATCH 1/2] New application : taboob

Flo weboob at flo.fourcot.fr
Wed Apr 2 14:41:41 CEST 2014


Hello,

sorry for the time for the reply, we was a little bit busy with the
Browser2 project.

Some comments inline:

Le 02/03/2014 23:26, Rudy Weber a écrit :
> 
> +class SongTab(CapBaseObject):
> +    """
> +    Song tab object.
> +    """
> +    title =      StringField('Title of the song')
> +    artist =       StringField('Artist of the song')
> +    type =       StringField('Type of tab')
> +    url =    StringField('Tab url of the song')
> +    content =   StringField('Tab of the song')
> +
> +    def __init__(self, id, title):
> +        CapBaseObject.__init__(self, id)
> +        self.title = title
> +

I think it should inherit of BaseFile, all field are already available
on it.

> +
> +class ICapTab(IBaseCap):
> +    """

Same problem here. It should be enough to inherit of ICapFile.

Else, I have nothing against adding a new application to download tabs.
Only small coding styles issues :

>     USER_AGENT = BaseBrowser.USER_AGENTS['wget']

Is wget really relevant here as user agent?

> print "Unknown criteria %s" % criteria

Please return an exception, a module can not print anything (use
something like UserError).




More information about the weboob mailing list