[weboob] [PATCH 1/1] Correction of bug #1292, about savings accounts of cragr module Now, the module can get history of all the accounts Also modification about classification of operations : using greedy regexp

Romain Bignon romain at symlink.me
Fri Nov 1 19:08:07 CET 2013


Hello,

Thank you for your patch. However, I have a remark about some of your changes:

On 27/Oct - 11:19, Bat Bast wrote:
> -            t.label = re.sub('(.*)  (.*)', r'\2', t.category).strip()
> +            t.label = re.sub('(.*?) (.*?)', r'\2', t.category).strip()
> -            t.category = re.sub('(.*)  .*', r'\1', t.category).strip()
> +            t.category = re.sub('(.*?) .*', r'\1', t.category).strip()
> -            t.label = re.sub('(.*)  .*', r'\1', t.label).strip()
> +            t.label = re.sub('(.*?) .*', r'\1', t.label).strip()

Why have you removed the two-spaces separator in regexpes?

Romain



More information about the weboob mailing list