[weboob] [PATCH 2/2] setup.py: be less confusing when make is missing

Adrien Kunysz adrien at kunysz.be
Sun Nov 4 15:06:32 CET 2012


When make is missing, setup.py prints a message suggesting to install
PyQt4-devel even if it already is. This change with the help of
6788c11a6d63824862d340f82da9de46ef63ee60 makes the message more helpful.

Before:
$ python setup.py
Building Qt applications
Install PyQt4-devel or disable Qt applications (with --no-qt).

After:
$ python setup.py
Building Qt applications
Could not find executable: make
Install missing component(s) (see above) or disable Qt applications (with --no-qt).

Signed-off-by: Adrien Kunysz <adrien at kunysz.be>
---
 setup.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/setup.py b/setup.py
index 40a3196..098a5f8 100755
--- a/setup.py
+++ b/setup.py
@@ -49,7 +49,7 @@ def build_qt():
     make = find_executable('make', ('gmake', 'make'))
     pyuic4 = find_executable('pyuic4', ('python2-pyuic4', 'pyuic4-2.7', 'pyuic4-2.6', 'pyuic4-2.5', 'pyuic4'))
     if not pyuic4 or not make:
-        print >>sys.stderr, 'Install PyQt4-devel or disable Qt applications (with --no-qt).'
+        print >>sys.stderr, 'Install missing component(s) (see above) or disable Qt applications (with --no-qt).'
         sys.exit(1)
 
     subprocess.check_call([make, '-C', 'weboob/applications/qboobmsg/ui', 'PYUIC=%s' % pyuic4])
-- 
1.7.2.5

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://lists.symlink.me/pipermail/weboob/attachments/20121104/f0e0bd76/attachment.sig>


More information about the weboob mailing list